-
Notifications
You must be signed in to change notification settings - Fork 28.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-45631][SS][PYSPARK] Remove @AbstractMethod from onQueryIdle in…
… PySpark StreamingQueryListener ### What changes were proposed in this pull request? Credit to anish-db for the initial investigation and the fix. This PR proposes to remove `abstractmethod` annotation from `onQueryIdle` in PySpark StreamingQueryListener. The function `onQueryIdle` was added with the annotation `abstractmethod`, which does not pick up default implementation and enforces users to implement the new method. This breaks all existing streaming query listener implementations and enforces them to add the dummy function implementation at least. This PR re-allows existing implementations to work properly without explicitly adding a new function `onQueryIdle`. ### Why are the changes needed? We broke backward compatibility in [SPARK-43183](https://issues.apache.org/jira/browse/SPARK-43183) and we want to fix it. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Modified tests. Now tests are verifying two different implementations covering old interface vs new interface. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #43483 from HeartSaVioR/SPARK-45631. Lead-authored-by: Jungtaek Lim <kabhwan.opensource@gmail.com> Co-authored-by: Anish Shrigondekar <anish.shrigondekar@databricks.com> Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com> (cherry picked from commit 75bc5ac) Signed-off-by: Jungtaek Lim <kabhwan.opensource@gmail.com>
- Loading branch information
1 parent
75a38b9
commit 06f4885
Showing
2 changed files
with
82 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters