Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16257: ZkStateReader changes to avoid race condition between collectionWatches and watchedCollectionStates #909

Merged
merged 45 commits into from
Jul 20, 2022
Merged

SOLR-16257: ZkStateReader changes to avoid race condition between collectionWatches and watchedCollectionStates #909

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
ac85088
ZkStateReader changes to avoid race condition for collectionWatches a…
patsonluk Jun 17, 2022
98813b2
Fixed missing javadoc values
patsonluk Jun 17, 2022
a14a53a
/gradlew :solr:solrj:spotlessApply
patsonluk Jun 17, 2022
548417c
Addressed :solr:solrj:validateLogCalls violations
patsonluk Jun 17, 2022
2189b3a
/gradlew :solr:solrj:spotlessApply
patsonluk Jun 17, 2022
aa026d6
Fixed DocCollectionWatches to keep a set of active collections to mai…
patsonluk Jun 17, 2022
07611a1
Code cleanup
patsonluk Jun 17, 2022
4a6d6a2
forciblyRefreshAllClusterStateSlow should use key set in collectionWa…
patsonluk Jun 17, 2022
7a8f960
Fixed DocCollectionWatches to keep a set of active collections to mai…
patsonluk Jun 17, 2022
eaa0211
/gradlew :solr:solrj:spotlessApply
patsonluk Jun 17, 2022
027436b
Added unit test cases
patsonluk Jun 18, 2022
d94a38b
./gradlew :solr:solrj:spotlessApply
patsonluk Jun 18, 2022
8f87fd8
Fixed check error
patsonluk Jun 18, 2022
174b5c4
Fixed gradle check
patsonluk Jun 18, 2022
8c32e86
Code cleanup
patsonluk Jun 18, 2022
1bfedb7
./gradlew :solr:solrj:spotlessApply
patsonluk Jun 18, 2022
44243f6
Reproduce race condition more consistently in ZkStateReaderTest
patsonluk Jun 21, 2022
22aa937
./gradlew :solr:solrj:spotlessApply
patsonluk Jun 21, 2022
c74c86b
Code cleanup
patsonluk Jun 21, 2022
1861dba
Code cleanup
patsonluk Jun 21, 2022
479227d
Fixed unit test cases
patsonluk Jun 21, 2022
d7b85e4
Do not use * for imports
patsonluk Jun 21, 2022
fbc91ff
./gradlew :solr:solrj:spotlessApply
patsonluk Jun 22, 2022
d8ceb10
Update solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader…
patsonluk Jun 30, 2022
33c99f4
Code cleanup/renaming after code review
patsonluk Jun 30, 2022
cc314e6
Code changes after code review
patsonluk Jul 1, 2022
a293166
./gradlew :solr:core:spotlessApply
patsonluk Jul 1, 2022
658d5b7
Refactoring after review. Creating a new branch as this seems to fail…
patsonluk Jul 6, 2022
07730f5
Refactoring after review. Creating a new branch as this seems to fail…
patsonluk Jul 6, 2022
90a3498
Refactoring after review. Creating a new branch as this seems to fail…
patsonluk Jul 6, 2022
3749dbc
Fixed incorrect static field
patsonluk Jul 7, 2022
c0577d6
Fixed unit test cases inti
patsonluk Jul 7, 2022
be48a38
Change after code review
patsonluk Jul 7, 2022
ac0c077
./gradlew :solr:core:spotlessApply and updated comment
patsonluk Jul 7, 2022
3edf561
./gradlew :solr:solrj:spotlessApply
patsonluk Jul 7, 2022
24a05df
Changes after code review
patsonluk Jul 7, 2022
c39e2a9
Use delay injection in race condition unit test case instead of runni…
patsonluk Jul 14, 2022
0feb4e6
Further improved the unit test case
patsonluk Jul 14, 2022
45181fb
Update solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader…
patsonluk Jul 14, 2022
c0dfcf8
Added comment for concurrent access concerns
patsonluk Jul 15, 2022
14afab4
Changes after code review
patsonluk Jul 15, 2022
7bad924
Added extra unit test case on zk version handling.
patsonluk Jul 15, 2022
2ab50d4
./gradlew :solr:core:spotlessApply
patsonluk Jul 15, 2022
d3e6688
More precise check condition
patsonluk Jul 15, 2022
e300041
Update CHANGES.txt
patsonluk Jul 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions solr/CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,9 @@ Improvements

* SOLR-16225: Upgrade dependencies (Carrot2, HPPC) (Dawid Weiss)

* SOLR-16257: Improve ZkStateReader to avoid race condition between collectionWatches and watchedCollectionStates
(Patson Luk, Houston Putman, Mike Drob)

Optimizations
---------------------
* SOLR-16120: Optimise hl.fl expansion. (Christine Poerschke, David Smiley, Mike Drob)
Expand Down
Loading