Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license check in go library testify #93

Merged
merged 1 commit into from
Feb 19, 2022

Conversation

mrproliu
Copy link
Contributor

I use the logrus library in the go and it's dependent on the old version of the testify library. After I run dep check, the license of this library could not analyze.

Here is the LICENSE file link: https://raw.githubusercontent.com/stretchr/testify/v1.2.2/LICENSE

@mrproliu mrproliu added the enhancement New feature or request label Feb 19, 2022
@mrproliu mrproliu added this to the 0.3.0 milestone Feb 19, 2022
@mrproliu mrproliu requested a review from kezhenxu94 February 19, 2022 02:56
Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a BSD

@mrproliu
Copy link
Contributor Author

It's an MIT license.

@wu-sheng
Copy link
Member

So this is ignoring the line?

@mrproliu
Copy link
Contributor Author

Yes. I think It's a note added by the Contributor and could be ignored to complete the license check.

Copy link
Member

@wu-sheng wu-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for @kezhenxu94

@kezhenxu94 kezhenxu94 merged commit 1f31717 into apache:main Feb 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants