Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support display version property for dependency resolve #78

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Support display version property for dependency resolve #78

merged 2 commits into from
Oct 12, 2021

Conversation

mrproliu
Copy link
Contributor

@mrproliu mrproliu commented Oct 11, 2021 •
edited
Loading

  1. Support display version property for dependency resolve command.
  2. Using go mod download -json to list all packages in golang resolver, go list can't list cached package Dir property.

Support display version property resolvers:

  • maven
  • go
  • npm

@mrproliu mrproliu added the enhancement New feature or request label Oct 11, 2021
@mrproliu mrproliu added this to the 0.2.0 milestone Oct 11, 2021
@mrproliu mrproliu requested a review from kezhenxu94 October 11, 2021 16:20
kezhenxu94
kezhenxu94 reviewed Oct 12, 2021
View reviewed changes
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM

pkg/deps/golang.go Outdated Show resolved Hide resolved
@kezhenxu94 kezhenxu94 merged commit 0eaf2c1 into apache:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mrproliu @kezhenxu94