Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the save location problem #70

Merged
merged 1 commit into from
Sep 15, 2021
Merged

fix the save location problem #70

merged 1 commit into from
Sep 15, 2021

Conversation

zooltd
Copy link
Contributor

@zooltd zooltd commented Sep 15, 2021

During resolving licenses, the working directory of the process would change. In this situation, if the output location a user inputed is a relative path, then the saving location would be different from what it was defined at first.

@wu-sheng wu-sheng requested a review from kezhenxu94 September 15, 2021 00:45
@wu-sheng wu-sheng added the bug Something isn't working label Sep 15, 2021
@wu-sheng wu-sheng added this to the 0.2.0 milestone Sep 15, 2021
Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!! 🙇🏻

@kezhenxu94 kezhenxu94 merged commit 8157269 into apache:main Sep 15, 2021
@zooltd zooltd deleted the fix/save branch September 15, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants