-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce Docker image size and add npm env to resolve npm projects' dependencies #59
Conversation
@zooltd what's the size for now? |
206.37 MB |
Nice 👍🏻 |
Run the docker container to resolve licenses on https://github.com/apache/skywalking-eyes and https://github.com/apache/skywalking-nodejs simultaneously , the output is shown below: root@Samaritan:~/test# docker run -it --rm -v $(pwd):/github/workspace license-eye d r
env: can't execute 'bash': No such file or directory npm ERR! A complete log of this run can be found in:
ERROR failed to identify the licenses of following packages (7): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works well. Nice work! 🙇🏻
@zooltd What is this for? It seems unrelated to this PR. |
Oh, I was only trying to test the updated Docker image. |
we don't need the entire golang development environment, instead, we only need the golang CLI tool to help us resolve packages.