Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor error #36

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Fix minor error #36

merged 1 commit into from
Jul 8, 2021

Conversation

MoGuGuai-hzr
Copy link
Contributor

Reading an file named "" will raise the IsNotExist error, so the conditional statement is unnecessary in pkg/config/config.go

The result should match whether the pattern is . or ./.

Small improvement.

@wu-sheng wu-sheng requested review from kezhenxu94 and fgksgf July 7, 2021 13:02
@wu-sheng wu-sheng added the bug Something isn't working label Jul 7, 2021
@wu-sheng
Copy link
Member

wu-sheng commented Jul 7, 2021

Reading an file named "" will raise the IsNotExist error, so the conditional statement is unnecessary in pkg/config/config.go

The result should match whether the pattern is . or ./.

Small improvement.

Thanks for the feedback, where are you going to use SkyWalking-eye tool?

@wu-sheng wu-sheng added this to the 0.2.0 milestone Jul 7, 2021
@MoGuGuai-hzr
Copy link
Contributor Author

Reading an file named "" will raise the IsNotExist error, so the conditional statement is unnecessary in pkg/config/config.go
The result should match whether the pattern is . or ./.
Small improvement.

Thanks for the feedback, where are you going to use SkyWalking-eye tool?

Yes, i will. And i am a student participating Summer 2021 of Open Source Promotion Plan.

Copy link
Member

@kezhenxu94 kezhenxu94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @MoGuGuai-hzr very much 🙇🏻 nice catches!

@kezhenxu94 kezhenxu94 merged commit 95d8dc0 into apache:main Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants