Add documentation about how to use via docker image #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wu-sheng
reviewed
Jan 12, 2021
Comment on lines
+19
to
+20
| # TODO: minimize the docker image size, now 524MB !!! | ||
|
|
There was a problem hiding this comment.
Didn't notice this before because I used alpine as base image, maybe because I use apk to download some dependencies inside the image, need sometime to investigate and minimize it
There was a problem hiding this comment.
After compressed, it's 184MB, https://hub.docker.com/repository/docker/apache/skywalking-eyes/tags?page=1&ordering=last_updated
wu-sheng
approved these changes
Jan 12, 2021
alexaguilar89
added a commit
to alexaguilar89/skywalking-eyes
that referenced
this pull request
Jan 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker image is really large, still pushing....