Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hintValueContext to replace extract sql hint from sql statement for solving shadow sql hint bug #33063

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

strongduanmu
Copy link
Member

@strongduanmu strongduanmu commented Sep 30, 2024

Fixes #33045.

Changes proposed in this pull request:

  • Use hintValueContext to replace extract sql hint from sql statement for solving shadow sql hint bug
  • modify unit test

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu
Copy link
Member Author

image

@strongduanmu
Copy link
Member Author

image

@RaigorJiang RaigorJiang merged commit 09c4034 into apache:master Sep 30, 2024
141 of 142 checks passed
@strongduanmu strongduanmu deleted the dev-0930 branch September 30, 2024 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ShardingProxy 5.5.0 version: SQL cannot to be routed to the shadow database data source for execution.
3 participants