Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new line for YAML configuration #577

Closed
nobody2014100 opened this issue Jan 24, 2018 · 4 comments
Closed

Support new line for YAML configuration #577

nobody2014100 opened this issue Jan 24, 2018 · 4 comments
Assignees

Comments

@nobody2014100
Copy link

Please answer these questions before submitting your issue. Thanks!

获取数据源换行
String dataSources = propertyResolver.getProperty("names");

建议 OrchestrationSpringBootConfiguration文件

line77

String dataSources = propertyResolver.getProperty("names");

加一个去空格处理

改为 String dataSources = propertyResolver.getProperty("names").trim();

Which version of Sharding-Jdbc do you using?

Expected behavior

Actual behavior

Steps to reproduce the behavior

Please provide the reproduce example codes (such as github link)

Code should based on https://github.com/shardingjdbc/sharding-jdbc-example

@terrymanu
Copy link
Member

terrymanu commented Jan 24, 2018

能否提供具体配置。yaml的标准配置是可以换行么?能否提供相关的参考信息

@nobody2014100
Copy link
Author

yaml支持换行的
imagecnak
参考http://www.ruanyifeng.com/blog/2016/07/yaml.html?f=tt
由于换行会转换为空格,所以处理过程会出错

@terrymanu
Copy link
Member

感谢提供参考意见。能否提供pull request,使您成为sharding-jdbc的贡献者。
谢谢

terrymanu added a commit that referenced this issue Jan 29, 2018
修复yaml换行导致的配置多了空格问题  @issue #577
@terrymanu
Copy link
Member

fixed at 2.0.3

@terrymanu terrymanu changed the title yaml配置换行问题 Support new line for YAML configuration Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants