Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute engine enhancement #1205

Closed
12 tasks done
terrymanu opened this issue Aug 29, 2018 · 0 comments
Closed
12 tasks done

Execute engine enhancement #1205

terrymanu opened this issue Aug 29, 2018 · 0 comments
Assignees
@terrymanu
Labels
type: enhancement

Comments

@terrymanu
Copy link
Member

terrymanu commented Aug 29, 2018 •
edited
Loading

  • Use max.connections.size.per.query to control concurrency for database access on CONNECTION_STRICTLY model
  • max.connections.size.per.query greater than table routed count, use MEMORY_STRICTLY automatically
  • When table routed count more than maximumPoolSize, use CONNECTION_STRICTLY mode automatically
  • Check max.connections.size.per.query must less or equal to maximumPoolSize in Sharding-Proxy (Sharding-JDBC cannot check because of connection pool is provided by end user)
  • Hide configuration for MEMORY_STRICTLY & CONNECTION_STRICTLY, just use max.connections.size.per.query to switch model smartly
  • Reuse connection if not call close
  • Handle get connection for dead lock
    • Get connection sync by data source for MEMORY_STRICTLY, because MEMORY_STRICTLY will hold connection until all query finished
    • Get connection async if connection size is 1
  • improve get connection performance
    • Get connection sync for XA transaction
    • Get connection sync for local transaction and BASE transaction
@terrymanu terrymanu self-assigned this Aug 29, 2018
This was referenced Aug 29, 2018
Closed
Closed
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
fix #1205, remove isReturnGeneratedKeys from SQLExecutePrepareCallback
6ef1a0f
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
fix #1205, move io.shardingsphere.core.executor.sql => io.shardingsph…
78ea549 
…ere.core.executor.sql.execute
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
fix #1205, use data node instead of actual table name on table metadata
44cbca7
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
fix #1205, remove useless key for group execution
0593fe0
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
fix #1205, move SQLRouteResult.getSQLUnitGroups => SQLExecutePrepareT…
b94a8ee 
…emplate
@terrymanu terrymanu reopened this Sep 1, 2018
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
fix #1205, use collection instead of map on group execute
3e258ac
@terrymanu terrymanu reopened this Sep 1, 2018
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
for #1205, refine javadoc
73896c7
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
for #1205, refactor SQLExecutionEvent, use SQLExecutionUnit instead o…
1636e7b 
…f dataSource & sqlUnit
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
for #1205, SQLExecutionUnit => RouteUnit
8b21eae
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
for #1205, SQLRouteResult.executionUnits => SQLRouteResult.routeUnit
c0c4a6b
terrymanu added a commit that referenced this issue Sep 1, 2018
@terrymanu
for #1205, refactor SQLRouteResult.routeUnit's type from set to colle…
2980694 
…ction
terrymanu added a commit that referenced this issue Sep 2, 2018
@terrymanu
for #1205, StatementExecuteUnit => SQLExecuteUnit
f5d8cc5
@terrymanu terrymanu assigned tristaZero and unassigned terrymanu Sep 5, 2018
@tristaZero tristaZero mentioned this issue Sep 17, 2018
Merged
@terrymanu terrymanu reopened this Sep 18, 2018
@terrymanu terrymanu self-assigned this Sep 18, 2018
terrymanu added a commit that referenced this issue Sep 18, 2018
@terrymanu
for #1205, Reuse connection if not call close
608f9a3
terrymanu added a commit that referenced this issue Sep 18, 2018
@terrymanu
for #1205, Reuse connection if not call close
098e6f4
terrymanu added a commit that referenced this issue Sep 19, 2018
@terrymanu
for #1205, Get connection sync to prevent dead lock for sharding-jdbc
f38351a
terrymanu added a commit that referenced this issue Sep 19, 2018
@terrymanu
for #1205, Get connection sync to prevent dead lock for sharding-proxy
23db595
terrymanu added a commit that referenced this issue Sep 19, 2018
@terrymanu
for #1205, sync data source map for Get connection sync to prevent de…
874e9ab 
…ad lock
terrymanu added a commit that referenced this issue Sep 19, 2018
@terrymanu
for #1205, sync SQLExecutePrepareTemplate for Get connection sync to …
58f684d 
…prevent dead lock
terrymanu added a commit that referenced this issue Sep 20, 2018
@terrymanu
for #1205, remove sync for SQLExecutePrepareTemplate and recover sync…
1f7c0be 
… for get connections on same data source, because data source map always use same hash sequence to iterator entries
@terrymanu terrymanu changed the title Optimize and simplify MEMORY_STRICTLY & CONNECTION_STRICTLY model Execute engine enhancement Sep 23, 2018
@terrymanu terrymanu reopened this Sep 23, 2018
terrymanu added a commit that referenced this issue Sep 23, 2018
@terrymanu
for #1205, Get connection sync for local transaction and BASE transac…
dd46bb9 
…tion
terrymanu added a commit that referenced this issue Sep 23, 2018
@terrymanu
for #1205, refactor constructor of SQLExecutePrepareTemplate
320c370
terrymanu added a commit that referenced this issue Sep 23, 2018
@terrymanu
for #1205, sync cached connections when get connection for concurrency
945ed17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrymanu terrymanu

Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@terrymanu @tristaZero