[SEDONA-229] Remove Duplicate String Check #787
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did you read the Contributor Guide?
Is this PR related to a JIRA ticket?
What changes were proposed in this PR?
This PR disables the scalastyle check called MultipleStringLiteralsChecker. This check is responsible for detecting multiple occurrences of the same string literal in the same file. From what I could gather, the reason for this check is to detect potential cases of "magic numbers" or constants that should be consolidated into a constant variable. There are three issues with this check:
This check did reveal some refactor points in the tests, but I would think that folks could already see that the tests could use some refactoring. In other words, this check doesn't flag anything that isn't obvious without it.
I did give a go at removing all duplicate strings for the sedona sql module and it led to some really ugly constant declarations in the test classes. Some nice refactors of the tests did fall out, and I will try to PR those once the linter messages are cleaned up.
How was this patch tested?
Ran the standard build process. This doesn't change any actual code.
Did this PR include necessary documentation updates?