Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix the R test that still has DBI call #721

Closed
wants to merge 1 commit into from
Closed

Conversation

jiayuasu
Copy link
Member

@jiayuasu jiayuasu commented Dec 2, 2022

Did you read the Contributor Guide?

Is this PR related to a JIRA ticket?

  • No, this is a documentation update. The PR name follows the format [DOCS] my subject.

What changes were proposed in this PR?

How was this patch tested?

Did this PR include necessary documentation updates?

  • No, this PR does not affect any public API so no need to change the docs.

@jiayuasu
Copy link
Member Author

@yitao-li Dear Yitao, could you please help me remove the DBI call in the test? My PR didn't work for this...

@jiayuasu jiayuasu requested a review from yitao-li December 10, 2022 21:39
Copy link
Contributor

@yitao-li yitao-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@yitao-li
Copy link
Contributor

Uh just noticed the build failures... ok I'll take a look soon

Copy link
Contributor

@yitao-li yitao-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix test failure (should be simple, I think) -- looking into it now

@yitao-li
Copy link
Contributor

yitao-li commented Dec 12, 2022

@jiayuasu I think #731 should fix it.
The CI run for that PR was cancelled after some unrelated test failure though, but if I run my version of sdf_sql(...) %>% collect() locally, I do get the expected result, so, I think it should work.

EDIT: actually all R builds are passing now in that PR ✅

@jiayuasu jiayuasu closed this Dec 13, 2022
@jiayuasu jiayuasu deleted the sedona-1.3.0 branch April 30, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants