Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEDONA-705] Add unique partitioner wrapper to enable partitioned writes with Sedona #1778
[SEDONA-705] Add unique partitioner wrapper to enable partitioned writes with Sedona #1778
Changes from 20 commits
f5c8437
67afcb8
79570ab
a6e7a09
b588be8
cc5324d
1bb9351
c3a256d
bb7cbff
dc4c3ce
d4eb46c
d19e81f
fa4691d
6140547
ac137e9
9c0a184
d709d06
f0e70d3
aaa6603
827a0e7
2202653
8189c82
5acabb5
f225522
e67e454
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy to move this to another PR...it's basically what it takes to get VSCode's Python testing integration to enable run/debug/discover.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could also just take
it.Next()
here (i.e., always return the first one) and modify theplaceObject
implementations to not return an iterator off of aHashSet
(i.e., write our own implementation ofIterator
, which might be better anyway).The motivation here is to ensure that the output is deterministic (i.e., if you set grids and ask Sedona to partition, you'll get the same result if you run your pipeline today or tomorrow).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm OK with your current approach. We'd better add comment to the code selecting the partitioning result with the minimum partition id to signify that this is for producing consistent result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This aligns the default between the
IndexedGridPartitioner
and theFlatGridPartitioner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A cleaner way to do this would probably be to remove the
gridType
andgrids
field and makegetGridType()
andgetGrids()
abstract? I could also remove this constructror and just pass theGenericUniquePartitioner
's parent grids/grid type through here.