[Feature][Catalog] Add InMemoryCatalog for test and add new getCatalogTableFromConfig method #5485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Hisoka-X
commented
Sep 14, 2023
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java
Show resolved
Hide resolved
| @@ -61,12 +56,7 @@ public void testSimpleSchemaParse() throws FileNotFoundException, URISyntaxExcep | |||
| @Test | |||
| public void testComplexSchemaParse() throws FileNotFoundException, URISyntaxException { | |||
| String path = getTestConfigFile("/conf/complex.schema.conf"); | |||
| Config config = | |||
| @@ -56,11 +54,4 @@ public interface CatalogOptions { | |||
| .withDescription( | |||
| "The table names RegEx of the database to capture." | |||
| + "The table name needs to include the database name, for example: database_.*\\.table_.*"); | |||
|
|
|||
| OptionRule.Builder BASE_RULE = | |||
There was a problem hiding this comment.
I also removed some useless code.
Hisoka-X
commented
Sep 14, 2023
| * </a> | ||
| */ | ||
| @Deprecated | ||
| public static List<CatalogTable> getCatalogTablesFromConfig( |
There was a problem hiding this comment.
after we delete getCatalogTables method, I will change this method name to getCatalogTables
ruanwenjun
reviewed
Sep 15, 2023
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java
Show resolved
Hide resolved
…gTableFromConfig method
Hisoka-X
force-pushed
the
catalog_refactor
branch
from
39b207d
to
12e6a42
Compare
liugddx
reviewed
Sep 17, 2023
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/InMemoryCatalog.java
Outdated
Show resolved
Hide resolved
|
Is this not triggering CI? |
Triggered. But not async with main repo. Let me investigate it. |
hailin0
approved these changes
Sep 19, 2023
|
Thanks @liugddx @hailin0 @Carl-Zhou-CN @ruanwenjun |
gnehil
pushed a commit
to gnehil/seatunnel
that referenced
this pull request
Oct 12, 2023
…gTableFromConfig method (apache#5485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
getCatalogTableFromConfigmethod, so that we can directly getCatalogTablefrom source config. It will be used when refactor Catalog for move createCatalogTablelogic toTableSourceFactoryinstance.InMemoryCatalog, after this we can test catalog without any third party database.Check list
New License Guide
release-note.