-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Catalog] Add InMemoryCatalog for test and add new getCatalogTableFromConfig method #5485
Conversation
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java
Show resolved
Hide resolved
@@ -61,12 +56,7 @@ public void testSimpleSchemaParse() throws FileNotFoundException, URISyntaxExcep | |||
@Test | |||
public void testComplexSchemaParse() throws FileNotFoundException, URISyntaxException { | |||
String path = getTestConfigFile("/conf/complex.schema.conf"); | |||
Config config = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -56,11 +54,4 @@ public interface CatalogOptions { | |||
.withDescription( | |||
"The table names RegEx of the database to capture." | |||
+ "The table name needs to include the database name, for example: database_.*\\.table_.*"); | |||
|
|||
OptionRule.Builder BASE_RULE = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also removed some useless code.
* </a> | ||
*/ | ||
@Deprecated | ||
public static List<CatalogTable> getCatalogTablesFromConfig( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after we delete getCatalogTables
method, I will change this method name to getCatalogTables
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java
Outdated
Show resolved
Hide resolved
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtilTest.java
Show resolved
Hide resolved
…gTableFromConfig method
39b207d
to
12e6a42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
seatunnel-api/src/test/java/org/apache/seatunnel/api/table/catalog/InMemoryCatalog.java
Outdated
Show resolved
Hide resolved
Is this not triggering CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Thanks @liugddx @hailin0 @Carl-Zhou-CN @ruanwenjun |
…gTableFromConfig method (apache#5485)
Purpose of this pull request
getCatalogTableFromConfig
method, so that we can directly getCatalogTable
from source config. It will be used when refactor Catalog for move createCatalogTable
logic toTableSourceFactory
instance.InMemoryCatalog
, after this we can test catalog without any third party database.Check list
New License Guide
release-note
.