Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][Zeta] Fix submit job throw jobId NPE #5252

Closed
wants to merge 0 commits into from

Conversation

chaorongzhi
Copy link
Contributor

Purpose of this pull request

Fix the problem that jobId is null and job submission fails, and add documentation comments.

Check list

@hailin0 hailin0 changed the title [Fix][Zeta] Fix the problem that the job submission fails if the jobId is null [Hotfix][Zeta] Fix submit job throw jobId NPE Aug 9, 2023
@liugddx
Copy link
Member

liugddx commented Aug 9, 2023

Can you add a unit test?

@chaorongzhi
Copy link
Contributor Author

Can you add a unit test?

Sure, I'll add unit tests to the e2e module.

@chaorongzhi
Copy link
Contributor Author

Can you add a unit test?

@liugddx PTAL, I have added unit test.

@Hisoka-X
Copy link
Member

cc @zhibinF maybe you should take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants