[Feature][connector-v2][Iceberg] sink plugin #5072
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hailin0 @EricJoy2048 PTAL |
|
Thanks for your contribution, Here are some comments. |
liugddx
reviewed
Jul 14, 2023
| @@ -0,0 +1,48 @@ | |||
| package org.apache.seatunnel.connectors.seatunnel.iceberg.config; | |||
liugddx
reviewed
Jul 14, 2023
Comment on lines
9
to
15
| /** | ||
| * | ||
| * | ||
| * @author mustard | ||
| * @version 1.0 | ||
| * Create by 2023-07-05 | ||
| */ |
Comment on lines
6
to
12
| /** | ||
| * | ||
| * | ||
| * @author mustard | ||
| * @version 1.0 | ||
| * Create by 2023-07-05 | ||
| */ |
| * @version 1.0 | ||
| * Create by 2023-07-05 | ||
| */ | ||
| public interface DataConverter { |
| @@ -0,0 +1,219 @@ | |||
| package org.apache.seatunnel.connectors.seatunnel.iceberg.data; | |||
Comment on lines
22
to
28
| /** | ||
| * | ||
| * | ||
| * @author mustard | ||
| * @version 1.0 | ||
| * Create by 2023-07-05 | ||
| */ |
| * @version 1.0 | ||
| * Create by 2023-07-05 | ||
| */ | ||
| @RequiredArgsConstructor |
Comment on lines
31
to
37
| /** | ||
| * | ||
| * | ||
| * @author mustard | ||
| * @version 1.0 | ||
| * Create by 2023-07-05 | ||
| */ |
Comment on lines
10
to
17
|
|
||
| /** | ||
| * | ||
| * | ||
| * @author mustard | ||
| * @version 1.0 | ||
| * Create by 2023-07-05 | ||
| */ |
|
Run |
|
If you are contributing the connector code, please check that the following files are updated:
|
|
@liugddx PTAL |
Fix CI error. |
5 tasks
5 tasks
4 tasks
|
您好，您的邮件已经收到。
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Check list
New License Guide
release-note.