-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][connector-v2][Iceberg] sink plugin #5072
Conversation
@hailin0 @EricJoy2048 PTAL |
Thanks for your contribution, Here are some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please add document.
- Please add e2e test case.
@@ -0,0 +1,48 @@ | |||
package org.apache.seatunnel.connectors.seatunnel.iceberg.config; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add apache license.
/** | ||
* | ||
* | ||
* @author mustard | ||
* @version 1.0 | ||
* Create by 2023-07-05 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these.
/** | ||
* | ||
* | ||
* @author mustard | ||
* @version 1.0 | ||
* Create by 2023-07-05 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same above
* @version 1.0 | ||
* Create by 2023-07-05 | ||
*/ | ||
public interface DataConverter { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same above
@@ -0,0 +1,219 @@ | |||
package org.apache.seatunnel.connectors.seatunnel.iceberg.data; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same above
/** | ||
* | ||
* | ||
* @author mustard | ||
* @version 1.0 | ||
* Create by 2023-07-05 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same above
* @version 1.0 | ||
* Create by 2023-07-05 | ||
*/ | ||
@RequiredArgsConstructor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same above
/** | ||
* | ||
* | ||
* @author mustard | ||
* @version 1.0 | ||
* Create by 2023-07-05 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same above
|
||
/** | ||
* | ||
* | ||
* @author mustard | ||
* @version 1.0 | ||
* Create by 2023-07-05 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same above
Run |
If you are contributing the connector code, please check that the following files are updated:
|
@liugddx PTAL |
Fix CI error. |
您好,您的邮件已经收到。
|
Purpose of this pull request
Check list
New License Guide
release-note
.