Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2][RocketMQ] Add RocketMQ source and sink connector #4007

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

sunxiaojian
Copy link
Contributor

@sunxiaojian sunxiaojian commented Jan 30, 2023

Purpose of this pull request

#3018 RocketMQ source and sink connector

Check list

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -149,8 +149,10 @@ public void initializeState(FunctionInitializationContext initializeContext) thr
getStateName(),
Types.MAP(
BasicTypeInfo.INT_TYPE_INFO,
Types.LIST(PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO))
));
Types.LIST(PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

@sunxiaojian
Copy link
Contributor Author

sunxiaojian commented Jan 31, 2023

Add e2e testcase

reference https://github.com/apache/incubator-seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/connector-kafka-e2e

Thanks for reviewing the PR, I will solve it in a week

@sunxiaojian
Copy link
Contributor Author

@sunxiaojian
Copy link
Contributor Author

@hailin0 PTAL

@sunxiaojian
Copy link
Contributor Author

@hailin0 @EricJoy2048 PTAL

@sunxiaojian
Copy link
Contributor Author

@TyrantLucifer

Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunxiaojian
Copy link
Contributor Author

sunxiaojian commented Apr 12, 2023

Overall LGTM, You should update error codes in this document: https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/Error-Quick-Reference-Manual.md

@TyrantLucifer done

Copy link
Member

@TyrantLucifer TyrantLucifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your contribution!

@hailin0 hailin0 merged commit e333897 into apache:dev Apr 14, 2023
MonsterChenzhuo pushed a commit to MonsterChenzhuo/incubator-seatunnel that referenced this pull request Apr 19, 2023
ic4y pushed a commit to ic4y/incubator-seatunnel that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants