[Feature][Connector-V2][RocketMQ] Add RocketMQ source and sink connector #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hailin0
reviewed
Jan 31, 2023
| @@ -149,8 +149,10 @@ public void initializeState(FunctionInitializationContext initializeContext) thr | |||
| getStateName(), | |||
| Types.MAP( | |||
| BasicTypeInfo.INT_TYPE_INFO, | |||
| Types.LIST(PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO)) | |||
| )); | |||
| Types.LIST(PrimitiveArrayTypeInfo.BYTE_PRIMITIVE_ARRAY_TYPE_INFO) | |||
sunxiaojian
force-pushed
the
dev
branch
3 times, most recently
from
9fb766c
to
f9678fc
Compare
Thanks for reviewing the PR, I will solve it in a week |
sunxiaojian
force-pushed
the
dev
branch
18 times, most recently
from
bfc662f
to
f7f08cb
Compare
sunxiaojian
force-pushed
the
dev
branch
6 times, most recently
from
9a15c5c
to
2e7a52f
Compare
Added |
sunxiaojian
force-pushed
the
dev
branch
7 times, most recently
from
7633570
to
6a420a9
Compare
|
@hailin0 PTAL |
sunxiaojian
force-pushed
the
dev
branch
3 times, most recently
from
03d0e34
to
894d293
Compare
|
@hailin0 @EricJoy2048 PTAL |
3 tasks
There was a problem hiding this comment.
Overall LGTM, You should update error codes in this document: https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/Error-Quick-Reference-Manual.md
sunxiaojian
force-pushed
the
dev
branch
2 times, most recently
from
115f063
to
9ce6621
Compare
@TyrantLucifer done |
TyrantLucifer
approved these changes
Apr 14, 2023
hailin0
approved these changes
Apr 14, 2023
MonsterChenzhuo
pushed a commit
to MonsterChenzhuo/incubator-seatunnel
that referenced
this pull request
Apr 19, 2023
ic4y
pushed a commit
to ic4y/incubator-seatunnel
that referenced
this pull request
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
#3018 RocketMQ source and sink connector
Check list
New License Guide
release-note.