Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][CDC] Support write cdc changelog event in doris sink #3892

Closed
wants to merge 0 commits into from
Closed

[Feature][CDC] Support write cdc changelog event in doris sink #3892

wants to merge 0 commits into from

Conversation

john8628
Copy link
Contributor

@john8628 john8628 commented Jan 7, 2023

…s sink

Purpose of this pull request

#3726

Check list

@hailin0 hailin0 changed the title [Feature][connector][doris] Support write cdc changelog event in dori… [Feature][CDC] Support write cdc changelog event in doris sink Jan 7, 2023
@hailin0 hailin0 added cdc feature New feature labels Jan 7, 2023
@hailin0
Copy link
Member

hailin0 commented Jan 7, 2023

waiting for this pr merged and add e2e testcase

#3865

TaoZex
TaoZex reviewed Jan 7, 2023
View reviewed changes
...s/src/main/java/org/apache/seatunnel/connectors/doris/serialize/DorisColumnRowSerialize.java Outdated
}

private DorisRecord serializeUpsert(SeaTunnelRow row) {
SerializationSchema serializer = createSerializer(sinkConfig, rowType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling the createSerializer method on each row may affect performance.
How about calling the createSerializer method only once?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK， that's better ;

@hailin0
Copy link
Member

hailin0 commented Jan 12, 2023 •
edited
Loading

waiting for this pr merged and add e2e testcase

#3865

Please add e2e testcase
@john8628

@hailin0
Copy link
Member

hailin0 commented Jan 30, 2023

reference this pr add e2e
@john8628
#3865

@john8628
Copy link
Contributor Author

ok , thanks,i will work on it recently~

@john8628 john8628 force-pushed the doris-cdc branch 2 times, most recently from 453415e to 0ad664f Compare February 11, 2023 06:33
@john8628 john8628 closed this Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TaoZex TaoZex TaoZex left review comments

Assignees
No one assigned
Labels
cdc feature New feature Waiting for code update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@john8628 @hailin0 @TaoZex