Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Shade][Hadoop] Improve hadoop shade #3858

Merged
merged 1 commit into from
Jan 4, 2023
Merged

[Improve][Shade][Hadoop] Improve hadoop shade #3858

merged 1 commit into from
Jan 4, 2023

Conversation

wendongdi
Copy link
Contributor

reference #3855

Purpose of this pull request

Improve hadoop shade by including classes in package com.google.common.cache

I have compiled and deployed dev branch after coding , and run demo v2.streaming.conf.template successfully on flink-1.12.1

图片

@liugddx liugddx added the First-time contributor First-time contributor label Jan 4, 2023
EricJoy2048
EricJoy2048 approved these changes Jan 4, 2023
View reviewed changes
Copy link
Member

@EricJoy2048 EricJoy2048 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @CalvinKirs PTAL

@CalvinKirs CalvinKirs merged commit f69af2a into apache:dev Jan 4, 2023
@TyrantLucifer TyrantLucifer mentioned this pull request Jan 4, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@EricJoy2048 EricJoy2048 EricJoy2048 approved these changes

Assignees
No one assigned
Labels
approved First-time contributor First-time contributor reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wendongdi @CalvinKirs @EricJoy2048 @liugddx