-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Connector-V2] [Clickhouse] Improve Clickhouse File Connector #3416
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2fd355d
[Connector-V2] [Clickhouse] Improve Clickhouse File Connector
Hisoka-X 007d898
[Connector-V2] [Clickhouse] Improve Clickhouse File Connector
Hisoka-X eb67337
[Connector-V2] [Clickhouse] Improve Clickhouse File Connector
Hisoka-X 97d36f4
Update docs/en/connector-v2/sink/ClickhouseFile.md
Hisoka-X 8a0993b
[Clickhouse] Change Random number to Context index
Hisoka-X 903839e
[Connector-V2] [Clickhouse] Improve Clickhouse add compatible mode
Hisoka-X aa4c266
Merge branch 'dev' into improve_clickhousefile
Hisoka-X 2709630
[Connector-V2] [Clickhouse] Improve Clickhouse File Connector
Hisoka-X 6babe9a
[Improve][ClickhouseFile] Add ClickhouseFile config
Hisoka-X 63be4c8
[Improve][ClickhouseFile] Add ClickhouseFile config
Hisoka-X 436747d
Update docs/en/connector-v2/sink/ClickhouseFile.md
Hisoka-X File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
...e/seatunnel/connectors/seatunnel/clickhouse/sink/file/ClickhouseFileSinkAggCommitter.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.seatunnel.connectors.seatunnel.clickhouse.sink.file; | ||
|
|
||
| import org.apache.seatunnel.api.sink.SinkAggregatedCommitter; | ||
| import org.apache.seatunnel.common.utils.SeaTunnelException; | ||
| import org.apache.seatunnel.connectors.seatunnel.clickhouse.config.FileReaderOption; | ||
| import org.apache.seatunnel.connectors.seatunnel.clickhouse.shard.Shard; | ||
| import org.apache.seatunnel.connectors.seatunnel.clickhouse.sink.client.ClickhouseProxy; | ||
| import org.apache.seatunnel.connectors.seatunnel.clickhouse.state.CKFileAggCommitInfo; | ||
| import org.apache.seatunnel.connectors.seatunnel.clickhouse.state.CKFileCommitInfo; | ||
|
|
||
| import com.clickhouse.client.ClickHouseException; | ||
| import com.clickhouse.client.ClickHouseRequest; | ||
| import com.clickhouse.client.ClickHouseResponse; | ||
|
|
||
| import java.io.IOException; | ||
| import java.util.ArrayList; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| public class ClickhouseFileSinkAggCommitter implements SinkAggregatedCommitter<CKFileCommitInfo, CKFileAggCommitInfo> { | ||
|
|
||
| private final ClickhouseProxy proxy; | ||
| private final ClickhouseTable clickhouseTable; | ||
|
|
||
| public ClickhouseFileSinkAggCommitter(FileReaderOption readerOption) { | ||
| proxy = new ClickhouseProxy(readerOption.getShardMetadata().getDefaultShard().getNode()); | ||
| clickhouseTable = proxy.getClickhouseTable(readerOption.getShardMetadata().getDatabase(), | ||
| readerOption.getShardMetadata().getTable()); | ||
| } | ||
|
|
||
| @Override | ||
| public List<CKFileAggCommitInfo> commit(List<CKFileAggCommitInfo> aggregatedCommitInfo) throws IOException { | ||
| aggregatedCommitInfo.forEach(commitInfo -> commitInfo.getDetachedFiles().forEach((shard, files) -> { | ||
| try { | ||
| this.attachFileToClickhouse(shard, files); | ||
| } catch (ClickHouseException e) { | ||
| throw new SeaTunnelException("failed commit file to clickhouse", e); | ||
| } | ||
| })); | ||
| return new ArrayList<>(); | ||
| } | ||
|
|
||
| @Override | ||
| public CKFileAggCommitInfo combine(List<CKFileCommitInfo> commitInfos) { | ||
| Map<Shard, List<String>> files = new HashMap<>(); | ||
| commitInfos.forEach(infos -> infos.getDetachedFiles().forEach((shard, file) -> { | ||
| if (files.containsKey(shard)) { | ||
| files.get(shard).addAll(file); | ||
| } else { | ||
| files.put(shard, file); | ||
| } | ||
| })); | ||
| return new CKFileAggCommitInfo(files); | ||
| } | ||
|
|
||
| @Override | ||
| public void abort(List<CKFileAggCommitInfo> aggregatedCommitInfo) throws Exception { | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public void close() throws IOException { | ||
| proxy.close(); | ||
| } | ||
|
|
||
| private void attachFileToClickhouse(Shard shard, List<String> clickhouseLocalFiles) throws ClickHouseException { | ||
| ClickHouseRequest<?> request = proxy.getClickhouseConnection(shard); | ||
| for (String clickhouseLocalFile : clickhouseLocalFiles) { | ||
| ClickHouseResponse response = request.query(String.format("ALTER TABLE %s ATTACH PART '%s'", | ||
| clickhouseTable.getLocalTableName(), | ||
| clickhouseLocalFile.substring(clickhouseLocalFile.lastIndexOf("/") + 1))).executeAndWait(); | ||
| response.close(); | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add UT for
optionRule().