-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] influxdb sink connector #3174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-influxdb-e2e/pom.xml
Outdated
Show resolved
Hide resolved
...ector-influxdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/influxdb/InfluxdbIT.java
Outdated
Show resolved
Hide resolved
...ector-influxdb-e2e/src/test/java/org/apache/seatunnel/e2e/connector/influxdb/InfluxdbIT.java
Outdated
Show resolved
Hide resolved
...el-e2e/seatunnel-connector-v2-e2e/connector-influxdb-e2e/src/test/resources/log4j.properties
Outdated
Show resolved
Hide resolved
…5/incubator-seatunnel into influxdb_sink_connector
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this connector to seatunnel-dist/pom.xml
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
33c9ca7
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/influxdb/sink/InfluxDBSinkWriter.java
Outdated
Show resolved
Hide resolved
} | ||
} | ||
|
||
public synchronized void write(Point record) throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to add synchronized, the writer is a single-threaded operation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to add synchronized, the writer is a single-threaded operation
thinks,i have fixed it in new commit. PTAL
...rc/main/java/org/apache/seatunnel/connectors/seatunnel/influxdb/sink/InfluxDBSinkWriter.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of this pull request
refer to #3018
add Influxdb sink connector
Check list
New License Guide