-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Connector-V2] Add influxDB connector source #2697
Conversation
...-e2e/connector-influxdb-flink-e2e/src/test/resources/influxdb/influxdb_source_to_assert.conf
Outdated
Show resolved
Hide resolved
can you add e2e-testcase(spark)? |
there is a conflict of the okhttp jar between the Spark jar and the influxdb connector. |
@CalvinKirs PTAL |
We'd better be able to rename these jars @TyrantLucifer WDYT? |
Yes, aggre with @CalvinKirs , you can add |
It seems impossible to replace okhttp with httpclient. The okhttp jar is used internally by the influxdb-java.jar. |
This is really bad news. But don't worry, we also have the ultimate weapon, the |
It seems impossible to replace okhttp with httpclient. The okhttp jar is used internally by the influxdb-java.jar. Influxdb-java is the only way officially provided for accessing influxdb. Thanks for your advice. I'll try. By the way, is there any other case where the shade plugin is used by other connectors |
It seems impossible to replace okhttp with httpclient. The okhttp jar is used internally by the influxdb-java.jar. Influxdb-java is the only way officially provided for accessing influxdb. You can refer to https://maven.apache.org/plugins/maven-shade-plugin/examples/resource-transformers.html or see |
It seems impossible to replace okhttp with httpclient. The okhttp jar is used internally by the influxdb-java.jar. Influxdb-java is the only way officially provided for accessing influxdb. thks, The conflict has been resolved. |
...-e2e/connector-influxdb-flink-e2e/src/test/resources/influxdb/influxdb_source_to_assert.conf
Show resolved
Hide resolved
...-e2e/connector-influxdb-spark-e2e/src/test/resources/influxdb/influxdb_source_to_assert.conf
Show resolved
Hide resolved
@531651225 does this pr can review again? |
Okay, help me review, thks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.../java/org/apache/seatunnel/connectors/seatunnel/influxdb/converter/InfluxDBRowConverter.java
Outdated
Show resolved
Hide resolved
...org/apache/seatunnel/connectors/seatunnel/influxdb/source/InfluxDBSourceSplitEnumerator.java
Outdated
Show resolved
Hide resolved
|
||
@Override | ||
public List<InfluxDBSourceSplit> snapshotState(long checkpointId) throws Exception { | ||
return null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add split snapshot. you can see https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-connectors-v2/connector-iotdb/src/main/java/org/apache/seatunnel/connectors/seatunnel/iotdb/source/IoTDBSourceReader.java
already fixed
.../java/org/apache/seatunnel/connectors/seatunnel/influxdb/converter/InfluxDBRowConverter.java
Outdated
Show resolved
Hide resolved
if (shouldEnumerate) { | ||
Set<InfluxDBSourceSplit> newSplits = getInfluxDBSplit(); | ||
|
||
synchronized (stateLock) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fd8961a
to
f978297
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Purpose of this pull request
#1946
Add InfluxDB Connector Source
close #2595
Check list
New License Guide