FolderEdit: HTTP response splitting defense.

apache · Aug 27, 2021 · ea8abe1 · ea8abe1
1 parent b438911
commit ea8abe1
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/FolderEdit.java b/app/src/main/java/org/apache/roller/weblogger/ui/struts2/editor/FolderEdit.java
@@ -40,7 +40,7 @@
 // TODO: make this work @AllowedMethods({"execute","save"})
 public class FolderEdit extends UIAction implements ServletResponseAware {
 
-    private static Log log = LogFactory.getLog(FolderEdit.class);
+    private static final Log log = LogFactory.getLog(FolderEdit.class);
 
     // bean for managing form data
     private FolderBean bean = new FolderBean();
@@ -127,7 +127,10 @@ public String save() {
                     addMessage("folderForm.updated");
                 }
 
-                httpServletResponse.addHeader("folderId", folderId );
+                // HTTP response splitting defense
+                String sanetizedFolderID = folderId.replace("\n", "").replace("\r", "");
+
+                httpServletResponse.addHeader("folderId", sanetizedFolderID);
 
                 return SUCCESS;