fail faster to keep consistent state

apache · Apr 25, 2022 · 7fc4a6e · 7fc4a6e
1 parent 052ca2c
commit 7fc4a6e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java b/client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java
@@ -224,7 +224,7 @@ public DefaultLitePullConsumer(final String namespace, final String consumerGrou
     }
 
     @Override
-    public void start() throws MQClientException {
+    public synchronized void start() throws MQClientException {
         checkServiceState();
         setTraceDispatcher();
         setConsumerGroup(NamespaceUtil.wrapNamespace(this.getNamespace(), this.consumerGroup));

diff --git a/...t/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java b/...t/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java
@@ -84,7 +84,7 @@ public class DefaultLitePullConsumerImpl implements MQConsumerInner {
 
     private final ArrayList<FilterMessageHook> filterMessageHookList = new ArrayList<FilterMessageHook>();
 
-    private volatile ServiceState serviceState = ServiceState.CREATE_JUST;
+    private ServiceState serviceState = ServiceState.CREATE_JUST;
 
     protected MQClientInstance mQClientFactory;