Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] support handling settings command in Producer #682

Merged
merged 3 commits into from
Feb 21, 2024

Conversation

glcrazier
Copy link
Contributor

@glcrazier glcrazier commented Feb 21, 2024

Which Issue(s) This PR Fixes

Fixes #634
Fixes #598

Brief Description

I've refactored the way of processing telemetry commands. Now the transaction command from the server is processed in Producer instead of Client. The client with different types can handle telemetry command within its own impl block.

How Did You Test This Change?

run cargo test and example to make sure it works

@glcrazier glcrazier changed the title [rust] support handling telemetry command in Producer [rust] support handling settings command in Producer Feb 21, 2024
@glcrazier glcrazier marked this pull request as ready for review February 21, 2024 07:31
@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (65b70ed) 55.89% compared to head (e03f30b) 47.56%.
Report is 1 commits behind head on master.

Files Patch % Lines
rust/src/producer.rs 65.90% 41 Missing and 19 partials ⚠️
rust/src/simple_consumer.rs 38.88% 8 Missing and 3 partials ⚠️
rust/src/client.rs 64.28% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #682      +/-   ##
============================================
- Coverage     55.89%   47.56%   -8.34%     
  Complexity      668      668              
============================================
  Files           259      207      -52     
  Lines         15653    12344    -3309     
  Branches       3891     3701     -190     
============================================
- Hits           8750     5872    -2878     
+ Misses         6650     6195     -455     
- Partials        253      277      +24     
Flag Coverage Δ
nodejs ?
rust 79.32% <63.46%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glcrazier glcrazier force-pushed the dev/telemetry_command_support branch from 77f4af8 to 41ca02c Compare February 21, 2024 08:51
rust/src/producer.rs Outdated Show resolved Hide resolved
rust/src/producer.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@lizhanhui lizhanhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now things look good

@lizhanhui lizhanhui merged commit 2eedee0 into apache:master Feb 21, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants