-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rust] support handling settings command in Producer #682
[rust] support handling settings command in Producer #682
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #682 +/- ##
============================================
- Coverage 55.89% 47.56% -8.34%
Complexity 668 668
============================================
Files 259 207 -52
Lines 15653 12344 -3309
Branches 3891 3701 -190
============================================
- Hits 8750 5872 -2878
+ Misses 6650 6195 -455
- Partials 253 277 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
77f4af8
to
41ca02c
Compare
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now things look good
Which Issue(s) This PR Fixes
Fixes #634
Fixes #598
Brief Description
I've refactored the way of processing telemetry commands. Now the transaction command from the server is processed in Producer instead of Client. The client with different types can handle telemetry command within its own impl block.
How Did You Test This Change?
run cargo test and example to make sure it works