Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document TLS hostname verification option (#2403) #2794

Merged
merged 1 commit into from
Oct 17, 2018
Merged

Document TLS hostname verification option (#2403) #2794

merged 1 commit into from
Oct 17, 2018

Conversation

ivankelly
Copy link
Contributor

Inform the user why it is disabled by default and in which scenarios
they should enable it.

Master issue: #2403

@ivankelly
Document TLS hostname verification option (apache#2403)
06208a3 
Inform the user why it is disabled by default and in which scenarios
they should enable it.

Master issue: apache#2403
@ivankelly ivankelly added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. labels Oct 15, 2018
@ivankelly ivankelly added this to the 2.3.0 milestone Oct 15, 2018
@ivankelly ivankelly self-assigned this Oct 15, 2018
@ivankelly ivankelly requested review from sijie and jai1 October 15, 2018 12:31
merlimat
merlimat reviewed Oct 16, 2018
View reviewed changes
Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sijie
Copy link
Member

sijie commented Oct 17, 2018

run integration tests

@sijie sijie merged commit c848860 into apache:master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merlimat merlimat merlimat left review comments

@sijie sijie sijie approved these changes

@jai1 jai1 Awaiting requested review from jai1

Assignees

@ivankelly ivankelly

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ivankelly @sijie @merlimat