[improve][broker] Remove spamming logs for customized managed ledger #23862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
requested review from
lhotari,
codelipenghui,
zymap,
poorbarcode and
shibd
BewareMyPower
added
release/3.0.9
release/3.3.5
release/4.0.3
and removed
doc-not-needed
shibd
approved these changes
Jan 19, 2025
RobertIndie
approved these changes
Jan 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23862 +/- ##
============================================
+ Coverage 73.57% 74.13% +0.55%
+ Complexity 32624 31745 -879
============================================
Files 1877 1853 -24
Lines 139502 143598 +4096
Branches 15299 16307 +1008
============================================
+ Hits 102638 106453 +3815
+ Misses 28908 28746 -162
- Partials 7956 8399 +443
Flags with carried forward coverage won't be shown. Click here to find out more.
|
poorbarcode
pushed a commit
to poorbarcode/pulsar
that referenced
this pull request
Jan 23, 2025
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 31, 2025
…pache#23862) (cherry picked from commit a93e93d) (cherry picked from commit cae9f60)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 3, 2025
…pache#23862) (cherry picked from commit a93e93d) (cherry picked from commit cae9f60)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For a customized managed ledger implementation,
getCursors()might not return aManagedCursorContainer. In this case,updateOldPositionInfo()will return a failed future so thatmonitorBacklogQuotawill keep printing spamming logs.Modifications
Return a null completed future in
updateOldPositionInfoifgetCursors()does not return aManagedCursorContainer.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: