Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] support missing cluster level fine-granted permissions #23675

Merged
merged 6 commits into from
Dec 4, 2024

Conversation

mattisonchao
Copy link
Member

Motivation

Support missing cluster-level fine-granted permissions.

Modifications

  • Add missing tenant-level operations
  • Keep compatibility for existing superuser validation.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc-not-needed

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Dec 3, 2024
@mattisonchao mattisonchao added this to the 4.1.0 milestone Dec 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 67.20000% with 41 lines in your changes missing coverage. Please review.

Project coverage is 74.37%. Comparing base (bbc6224) to head (8c41d99).
Report is 774 commits behind head on master.

Files with missing lines Patch % Lines
.../apache/pulsar/broker/admin/impl/ClustersBase.java 67.77% 24 Missing and 5 partials ⚠️
...sar/broker/authorization/AuthorizationService.java 37.50% 6 Missing and 4 partials ⚠️
...ar/broker/authorization/AuthorizationProvider.java 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23675      +/-   ##
============================================
+ Coverage     73.57%   74.37%   +0.79%     
- Complexity    32624    34549    +1925     
============================================
  Files          1877     1945      +68     
  Lines        139502   147437    +7935     
  Branches      15299    16268     +969     
============================================
+ Hits         102638   109652    +7014     
- Misses        28908    29303     +395     
- Partials       7956     8482     +526     
Flag Coverage Δ
inttests 27.29% <2.40%> (+2.71%) ⬆️
systests 24.36% <2.40%> (+0.04%) ⬆️
unittests 73.76% <67.20%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ker/authorization/PulsarAuthorizationProvider.java 68.86% <100.00%> (+0.25%) ⬆️
.../pulsar/common/policies/data/ClusterOperation.java 100.00% <100.00%> (ø)
...apache/pulsar/common/policies/data/PolicyName.java 100.00% <100.00%> (ø)
...ar/broker/authorization/AuthorizationProvider.java 17.14% <33.33%> (-1.38%) ⬇️
...sar/broker/authorization/AuthorizationService.java 56.02% <37.50%> (-2.18%) ⬇️
.../apache/pulsar/broker/admin/impl/ClustersBase.java 84.02% <67.77%> (+3.53%) ⬆️

... and 664 files with indirect coverage changes

@mattisonchao mattisonchao merged commit 1c1a5cc into apache:master Dec 4, 2024
54 checks passed
mattisonchao added a commit that referenced this pull request Dec 4, 2024
mattisonchao added a commit that referenced this pull request Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants