Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] Install coreutils in docker image to improve compatibility #23667

Merged

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Dec 2, 2024

Resolves apache/pulsar-helm-chart#554

Motivation

Modifications

  • add coreutils package to the docker image. The size of coreutils is small, only about 1MB.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

- the timeout command provided by default busybox implementation in Alpine leaves zombie processes
  - see apache/pulsar-helm-chart#554
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.39%. Comparing base (bbc6224) to head (5b5c3c0).
Report is 771 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23667      +/-   ##
============================================
+ Coverage     73.57%   74.39%   +0.82%     
- Complexity    32624    34520    +1896     
============================================
  Files          1877     1944      +67     
  Lines        139502   147331    +7829     
  Branches      15299    16258     +959     
============================================
+ Hits         102638   109614    +6976     
- Misses        28908    29263     +355     
- Partials       7956     8454     +498     
Flag Coverage Δ
inttests 27.27% <ø> (+2.69%) ⬆️
systests 24.37% <ø> (+0.05%) ⬆️
unittests 73.77% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 665 files with indirect coverage changes

@lhotari lhotari merged commit f279055 into apache:master Dec 2, 2024
55 of 57 checks passed
lhotari added a commit that referenced this pull request Dec 6, 2024
lhotari added a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[timeout] <defunct> Zookeeper and Broker Pods Contain Zombie Processes
4 participants