[fix][test] Fix SimpleProducerConsumerTest.testMultiTopicsConsumerImplPauseForManualSubscription #23546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23546 +/- ##
============================================
+ Coverage 73.57% 74.32% +0.75%
- Complexity 32624 34331 +1707
============================================
Files 1877 1943 +66
Lines 139502 147050 +7548
Branches 15299 16209 +910
============================================
+ Hits 102638 109299 +6661
- Misses 28908 29313 +405
- Partials 7956 8438 +482
Flags with carried forward coverage won't be shown. Click here to find out more. |
visxu
pushed a commit
to vissxu/pulsar
that referenced
this pull request
Nov 6, 2024
…lPauseForManualSubscription (apache#23546)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 20, 2024
…lPauseForManualSubscription (apache#23546) (cherry picked from commit c4ee362) (cherry picked from commit b5c1c1c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 21, 2024
…lPauseForManualSubscription (apache#23546) (cherry picked from commit c4ee362) (cherry picked from commit b5c1c1c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23485
Motivation
After calling
pause(), there are still messages retained inincomingMessagesbecause the internalconsumerhas already pre fetched a message and placed it inincomingMessages.When calling pause(), these pre fetched messages are not immediately cleared, causing instability as messages can still be received during testing.
Modifications
A larger
receiverQueueSizeallows more messages to be prefetched and cached, ensuring that messages in the buffer are effectively managed after a pause operation, without causing message interference during testing.In a multi topic consumer environment, the
receiverQueueSizeshould be set reasonably. For multi topic consumers, the receiver Queue Size should be large enough to ensure that each internal ConsumerImpl instance can independently perform message prefetching without interfering with each other.receiverQueueSize 1 -> 6
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete