Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][build] Drop deprecated pulsar-client-1x and pulsar-client-2x-shaded modules #23450

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 13, 2024

Motivation

The Pulsar code base includes deprecated modules pulsar-client-1x and pulsar-client-2x-shaded which are related to a compatibility layer for Pulsar 1.x client api. This is deprecated and isn't used.

Modifications

  • drop pulsar-client-1x and pulsar-client-2x-shaded modules

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@lhotari lhotari added this to the 4.0.0 milestone Oct 13, 2024
@lhotari lhotari self-assigned this Oct 13, 2024
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.27%. Comparing base (bbc6224) to head (e9f60b4).
Report is 671 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23450      +/-   ##
============================================
+ Coverage     73.57%   74.27%   +0.70%     
- Complexity    32624    34369    +1745     
============================================
  Files          1877     1943      +66     
  Lines        139502   146913    +7411     
  Branches      15299    16179     +880     
============================================
+ Hits         102638   109120    +6482     
- Misses        28908    29359     +451     
- Partials       7956     8434     +478     
Flag Coverage Δ
inttests 27.31% <ø> (+2.72%) ⬆️
systests 24.37% <ø> (+0.05%) ⬆️
unittests 73.64% <ø> (+0.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 657 files with indirect coverage changes

@lhotari lhotari merged commit 4eb1a29 into apache:master Oct 14, 2024
54 of 57 checks passed
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test release/4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants