-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][broker][PIP-379] Don't replace a consumer when there's a collision #23441
[improve][broker][PIP-379] Don't replace a consumer when there's a collision #23441
Conversation
...c/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #23441 +/- ##
============================================
+ Coverage 73.57% 74.23% +0.66%
- Complexity 32624 34431 +1807
============================================
Files 1877 1953 +76
Lines 139502 147189 +7687
Branches 15299 16206 +907
============================================
+ Hits 102638 109272 +6634
- Misses 28908 29472 +564
- Partials 7956 8445 +489
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Fixes #23439
Motivation
When a consumer joins or leaves, the hash ranges from existing consumers shouldn't move from one to another.
Modifications
Documentation
doc
doc-required
doc-not-needed
doc-complete