[improve][broker] Reducing the parse of MessageMetadata in compaction

[aloyszhang]

Motivation

There are many redundant parses of MessageMetadata in topic compaction, including phase one and phase two

Modifications

reuse the MessageMetadata object in topic compaction

Verifying this change

• Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Documentation

• doc-not-needed

Matching PR in forked repository

PR in forked repository: aloyszhang#23

[github-actions]

@aloyszhang Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

[lhotari]

LGTM

Please check the questions.

[lhotari]

LGTM

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.51%. Comparing base (bbc6224) to head (3f3efad).
Report is 578 commits behind head on master.

Files with missing lines	Patch %	Lines
...che/pulsar/compaction/EventTimeOrderCompactor.java	50.00%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #23285      +/-   ##
============================================
+ Coverage     73.57%   74.51%   +0.93%     
+ Complexity    32624     2758   -29866     
============================================
  Files          1877     1927      +50     
  Lines        139502   145065    +5563     
  Branches      15299    15862     +563     
============================================
+ Hits         102638   108088    +5450     
+ Misses        28908    28704     -204     
- Partials       7956     8273     +317     

Flag	Coverage Δ
inttests	27.85% <11.11%> (+3.27%)	⬆️
systests	24.72% <11.11%> (+0.39%)	⬆️
unittests	73.85% <85.18%> (+1.00%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...g/apache/pulsar/client/impl/RawBatchConverter.java	94.79% <100.00%> (+0.88%)	⬆️
...e/pulsar/compaction/AbstractTwoPhaseCompactor.java	76.77% <100.00%> (ø)
...he/pulsar/compaction/PublishingOrderCompactor.java	93.18% <100.00%> (ø)
...che/pulsar/compaction/EventTimeOrderCompactor.java	35.82% <50.00%> (ø)

... and 557 files with indirect coverage changes

[lordcheng10]

LGTM