Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker] Add principal name into info log to enhance analysis and troubleshooting #23257

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

rdhabalia
Copy link
Contributor

@rdhabalia rdhabalia commented Sep 4, 2024

Motivation

Currently broker is logging principal-name and producer/consumer creation log into separate line which makes harder to to find out role-name that created producer/consumer which requires for troubleshooting and role-access analysis. Therefore, adding principal name into the same producer/consumer creation log line.

Modifications

add additional principal name parameter into the log line.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@rdhabalia rdhabalia added area/broker doc-not-needed Your PR changes do not impact docs ready-to-test labels Sep 4, 2024
@rdhabalia rdhabalia self-assigned this Sep 4, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.53%. Comparing base (bbc6224) to head (991b347).
Report is 561 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #23257      +/-   ##
============================================
+ Coverage     73.57%   74.53%   +0.96%     
- Complexity    32624    33770    +1146     
============================================
  Files          1877     1926      +49     
  Lines        139502   145039    +5537     
  Branches      15299    15862     +563     
============================================
+ Hits         102638   108109    +5471     
+ Misses        28908    28652     -256     
- Partials       7956     8278     +322     
Flag Coverage Δ
inttests 27.56% <100.00%> (+2.98%) ⬆️
systests 24.67% <100.00%> (+0.35%) ⬆️
unittests 73.89% <100.00%> (+1.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...va/org/apache/pulsar/broker/service/ServerCnx.java 72.37% <100.00%> (+0.23%) ⬆️

... and 556 files with indirect coverage changes

@nodece nodece requested review from lhotari and dao-jun September 5, 2024 05:04
@nodece nodece added this to the 4.0.0 milestone Sep 5, 2024
@rdhabalia rdhabalia merged commit 6c300f5 into apache:master Sep 5, 2024
53 of 55 checks passed
@rdhabalia rdhabalia deleted the principal_log branch September 5, 2024 06:34
michalcukierman pushed a commit to michalcukierman/pulsar that referenced this pull request Sep 11, 2024
hanmz pushed a commit to hanmz/pulsar that referenced this pull request Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants