[improve][admin] PIP-369 Change default value of unload-scope in ns-isolation-policy set
#23253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-isolation-policy set` Also change behavior of all_matching to cover both removed and added regexes
github-actions
bot
added
the
doc-required
|
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23253 +/- ##
============================================
+ Coverage 73.57% 74.54% +0.96%
- Complexity 32624 34289 +1665
============================================
Files 1877 1926 +49
Lines 139502 145039 +5537
Branches 15299 15858 +559
============================================
+ Hits 102638 108114 +5476
+ Misses 28908 28658 -250
- Partials 7956 8267 +311
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I just noticed. Why is the codecov diff comparing against a 6 months old commit rather than master's head? |
nodece
reviewed
Sep 11, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/ClustersBase.java
Outdated
Show resolved
Hide resolved
…l/ClustersBase.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
nodece
approved these changes
Sep 11, 2024
|
/pulsarbot rerun-failure-checks |
hanmz
pushed a commit
to hanmz/pulsar
that referenced
this pull request
Feb 12, 2025
…s-isolation-policy set` (apache#23253) Co-authored-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a followup to #23120 to make the backward incompatible change to:
unload-scopetochangedPIP: #23116
This change is only meant for pulsar 4.x release
Verifying this change
This change added tests and can be verified as follows:
all_matchingflagchangedDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: grssam#3