Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve] [pip] PIP-370: configurable remote topic creation in geo-replication #23124

Merged
merged 18 commits into from
Aug 16, 2024

Conversation

poorbarcode
Copy link
Contributor

@poorbarcode poorbarcode commented Aug 5, 2024

Motivation

Modifications

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: x

@poorbarcode poorbarcode added the PIP label Aug 5, 2024
@poorbarcode poorbarcode added this to the 3.4.0 milestone Aug 5, 2024
@poorbarcode poorbarcode self-assigned this Aug 5, 2024
@github-actions github-actions bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Aug 5, 2024
@Demogorgon314 Demogorgon314 self-requested a review August 5, 2024 11:59
pip/pip-370.md Outdated Show resolved Hide resolved
@lhotari
Copy link
Member

lhotari commented Aug 12, 2024

I think that the title "PIP-370: An optional flag: disable the replicators to automatically trigger topic creation" is slightly confusing. It could be misunderstood as "disable replicators so that topic creation is automatically triggered", which is not correct at all.
A better name would be "PIP-370: configurable remote topic creation in geo-replication" etc.

@poorbarcode poorbarcode changed the title [improve] [pip] PIP-370: An optional flag: disable the replicators to automatically trigger topic creation [improve] [pip] PIP-370: PIP-370: configurable remote topic creation in geo-replication Aug 12, 2024
@poorbarcode poorbarcode changed the title [improve] [pip] PIP-370: PIP-370: configurable remote topic creation in geo-replication [improve] [pip] PIP-370: configurable remote topic creation in geo-replication Aug 12, 2024
pip/pip-370.md Outdated Show resolved Hide resolved
pip/pip-370.md Outdated Show resolved Hide resolved
pip/pip-370.md Show resolved Hide resolved
pip/pip-370.md Outdated Show resolved Hide resolved
pip/pip-370.md Outdated Show resolved Hide resolved
@poorbarcode poorbarcode requested a review from lhotari August 13, 2024 14:02
@poorbarcode poorbarcode requested review from codelipenghui and removed request for codelipenghui August 14, 2024 12:25
pip/pip-370.md Outdated Show resolved Hide resolved
pip/pip-370.md Outdated Show resolved Hide resolved
pip/pip-370.md Outdated Show resolved Hide resolved
pip/pip-370.md Outdated Show resolved Hide resolved
pip/pip-370.md Outdated Show resolved Hide resolved
@poorbarcode poorbarcode merged commit 1f90897 into apache:master Aug 16, 2024
20 checks passed
grssam pushed a commit to grssam/pulsar that referenced this pull request Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants