-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker] PIP-264: Add OpenTelemetry managed cursor metrics #23000
Merged
merlimat
merged 13 commits into
apache:master
from
dragosvictor:dmisca-pip-264-managed-cursor-metrics
Jul 5, 2024
Merged
[feat][broker] PIP-264: Add OpenTelemetry managed cursor metrics #23000
merlimat
merged 13 commits into
apache:master
from
dragosvictor:dmisca-pip-264-managed-cursor-metrics
Jul 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ged-cursor-metrics
…ged-cursor-metrics
…ged-cursor-metrics
dao-jun
approved these changes
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/metrics
area/ML
doc-required
Your PR changes impact docs and you will update later.
ready-to-test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP-264
Motivation
Adds Managed Cursor metrics, as currently described here, to the OpenTelemetry pipeline.
Modifications
Verifying this change
This change modified tests and can be verified as follows:
ManagedCursorMetricsTest#testManagedCursorMetrics
andManagedCursorMetricsTest#testCursorReadWriteMetrics
to cover the OpenTelemetry metricsDoes this pull request potentially affect one of the following parts:
Documentation
doc
doc-required
[feat][doc] PIP-264: Add OpenTelemetry managed cursor metrics reference pulsar-site#929doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: dragosvictor#34