Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][pip] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources #22071

Merged
merged 3 commits into from
Feb 28, 2024

Conversation

jiangpengcheng
Copy link
Contributor

@jiangpengcheng jiangpengcheng commented Feb 19, 2024

PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources

Motivation

Make Pulsar Sinks and Sources able to send logs to a Pulsar topic.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added type/PIP doc-complete Your PR changes impact docs and the related docs have been already added. labels Feb 19, 2024
@lhotari
Copy link
Member

lhotari commented Feb 19, 2024

PIP-338 is already taken by #22039

@lhotari lhotari changed the title [improve][pip] PIP-338: Introducing the --log-topic Option for Pulsar Sinks and Sources [improve][pip] PIP-339: Introducing the --log-topic Option for Pulsar Sinks and Sources Feb 19, 2024
@Technoboy-
Copy link
Contributor

Please update the vote thread

@Technoboy- Technoboy- added this to the 3.3.0 milestone Feb 27, 2024
@Technoboy- Technoboy- merged commit 86b3203 into apache:master Feb 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-complete Your PR changes impact docs and the related docs have been already added. type/PIP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants