-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat][broker]PIP-255 Part-2: Make the partition assignment strategy pluggable #20537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make topic-bundle assignment strategy pluggable
Technoboy-
reviewed
Jun 8, 2023
...oker/src/main/java/org/apache/pulsar/common/naming/ConsistentHashingTopicBundleAssigner.java
Outdated
Show resolved
Hide resolved
315157973
reviewed
Jun 9, 2023
...oker/src/main/java/org/apache/pulsar/common/naming/ConsistentHashingTopicBundleAssigner.java
Outdated
Show resolved
Hide resolved
Technoboy-
reviewed
Jun 9, 2023
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundles.java
Outdated
Show resolved
Hide resolved
315157973
reviewed
Jun 14, 2023
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java
Show resolved
Hide resolved
315157973
reviewed
Jun 15, 2023
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentFactory.java
Outdated
Show resolved
Hide resolved
315157973
approved these changes
Jun 19, 2023
@Technoboy- PLAL |
BewareMyPower
requested changes
Jun 20, 2023
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundleFactory.java
Outdated
Show resolved
Hide resolved
...oker/src/main/java/org/apache/pulsar/common/naming/ConsistentHashingTopicBundleAssigner.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/NamespaceBundles.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentFactory.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentFactory.java
Outdated
Show resolved
Hide resolved
4 tasks
pulsar-broker/src/test/java/org/apache/pulsar/common/naming/NamespaceBundlesTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line break at the end of file
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategy.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategyTest.java
Outdated
Show resolved
Hide resolved
BewareMyPower
approved these changes
Jun 27, 2023
315157973
reviewed
Jun 27, 2023
pulsar-broker/src/main/java/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategy.java
Show resolved
Hide resolved
315157973
reviewed
Jun 27, 2023
pulsar-broker/src/test/org/apache/pulsar/common/naming/TopicBundleAssignmentStrategyTest.java
Outdated
Show resolved
Hide resolved
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #20537 +/- ##
============================================
+ Coverage 72.60% 73.12% +0.51%
- Complexity 32018 32053 +35
============================================
Files 1855 1869 +14
Lines 138569 138783 +214
Branches 15250 15264 +14
============================================
+ Hits 100605 101481 +876
+ Misses 29945 29266 -679
- Partials 8019 8036 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIP: #19806
Motivation
Make the partition assignment strategy pluggable
Modifications
broker find bundle api
Verifying this change
This change added tests
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository