Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][broker][branch-2.8] Fix potential to add duplicated consumer #16826

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

poorbarcode
Copy link
Contributor

Motivation

see #15051

There have conflicts when cherry-picking #15051 PR (branch 2.8 has no mock static support), so I created a separate PR to fix branch-2.8

Modifications

Swap the execution order of duplicate validation and maximum validation

Documentation

  • doc-required

  • doc-not-needed

  • doc

  • doc-complete

@poorbarcode
Copy link
Contributor Author

@BewareMyPower Could you take a look?

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@BewareMyPower
Copy link
Contributor

We can merge this PR once only CI - Unit / unit-tests (pull_request) failed because there is a broken test, see #16813.

@poorbarcode
Copy link
Contributor Author

/pulsarbot rerun-failure-checks

@BewareMyPower
Copy link
Contributor

Merge this PR first, it looks like NamespacesTest.testDeleteNamespaceWithBundles is also very flaky.

Wanted but not invoked:
asyncResponse.resume(<Capturing argument>);
-> at org.apache.pulsar.broker.admin.NamespacesTest.testDeleteNamespaceWithBundles(NamespacesTest.java:859)

However, there was exactly 1 interaction with this mock:
asyncResponse.resume(
    org.apache.pulsar.broker.web.RestException: Failed to find ownership for ServiceUnit:my-tenant/use/test-delete-namespace-with-bundles/0x00000000_0x80000000
);
-> at org.apache.pulsar.broker.web.PulsarWebResource.resumeAsyncResponseExceptionally(PulsarWebResource.java:1226)

@BewareMyPower BewareMyPower merged commit a3515ab into apache:branch-2.8 Jul 28, 2022
@poorbarcode poorbarcode deleted the cherry-pick-2.8/15051 branch September 17, 2022 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life release/2.8.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants