Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geo Replication #7

Closed
yiguolei opened this issue Sep 12, 2016 · 2 comments
Closed

Geo Replication #7

yiguolei opened this issue Sep 12, 2016 · 2 comments
Assignees
@merlimat
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.

Comments

@yiguolei
Copy link

Could you please show some details about Geo-Replication?
@merlimat
Copy link
Contributor

Yes, that was already in the queue. Thanks for bringing it up.

@merlimat merlimat self-assigned this Sep 12, 2016
@merlimat merlimat added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Sep 12, 2016
merlimat referenced this issue in merlimat/pulsar Sep 13, 2016
@merlimat
[#7] Added Geo-Replication documentation
5dae839
merlimat added a commit that referenced this issue Sep 13, 2016
@merlimat
[#7] Added Geo-Replication documentation (#10)
5771aa4
@merlimat
Copy link
Contributor

added documentation for geo-replication at https://github.com/yahoo/pulsar/blob/master/docs/GeoReplication.md

sijie referenced this issue in sijie/pulsar Mar 4, 2018
@sijie
Use TypeResolver to resolve generic types (#7)
9e7d30c
@liujiejie liujiejie mentioned this issue Mar 6, 2020
Closed
@firefeifei firefeifei mentioned this issue Jun 21, 2020
Closed
@klwilson227 klwilson227 mentioned this issue Aug 19, 2020
Closed
codelipenghui pushed a commit that referenced this issue Nov 12, 2020
@BewareMyPower
[C++] Fix potential crash caused by AckGroupTracker's timer (#8519)
cfa65d0 
### Motivation

The `AckGroupingTrackerEnabled`'s timer callback only captures `this`, which is a weak reference to the `AckGroupingTrackerEnabled ` instance. If the instance went out of the scope and destroyed, `this` would point to an invalid block.

Even if the destructor of `AckGroupingTrackerEnabled` cancels the timer, the callback may not be triggered immediately. There's still a possibility that when the callback is triggered, the error code is 0 but accessing to `this` is invalid. For example, there's a crash caused by the callback in production environment that is hard to reproduce:

```
#6 <signal handler called>
#7 0x00007fb4e67c5cb8 in ?? ()
#8 0x00007fb604981adb in operator() (ec=..., __closure=0x7fb52b0fb230)
   at /usr/local/src/apache-pulsar-microfocus/pulsar-client-cpp/lib/AckGroupingTrackerEnabled.cc:148
#9 operator() (this=0x7fb52b0fb230) at /usr/local/include/boost/asio/detail/bind_handler.hpp:47
```

### Modifications

- Use `std::shared_ptr` instead of `std::unique_ptr` for `AckGroupingTrackerEnabled`, then capture the shared pointer in timer callback's lambda expression to extend the lifetime of `this`.
- Add `start()` method to `AckGroupingTracker` to avoid `std::bad_weak_ptr` because `shared_from_this()` in a constructor returns a null pointer.
- Use `std::weak_ptr` to reference `HandlerBase` in case that the handler may be invalid when the timer callback is triggered.
github-actions bot pushed a commit that referenced this issue Nov 12, 2020
@BewareMyPower @codelipenghui
[C++] Fix potential crash caused by AckGroupTracker's timer (#8519)
056eb50 
### Motivation

The `AckGroupingTrackerEnabled`'s timer callback only captures `this`, which is a weak reference to the `AckGroupingTrackerEnabled ` instance. If the instance went out of the scope and destroyed, `this` would point to an invalid block.

Even if the destructor of `AckGroupingTrackerEnabled` cancels the timer, the callback may not be triggered immediately. There's still a possibility that when the callback is triggered, the error code is 0 but accessing to `this` is invalid. For example, there's a crash caused by the callback in production environment that is hard to reproduce:

```
#6 <signal handler called>
#7 0x00007fb4e67c5cb8 in ?? ()
#8 0x00007fb604981adb in operator() (ec=..., __closure=0x7fb52b0fb230)
   at /usr/local/src/apache-pulsar-microfocus/pulsar-client-cpp/lib/AckGroupingTrackerEnabled.cc:148
#9 operator() (this=0x7fb52b0fb230) at /usr/local/include/boost/asio/detail/bind_handler.hpp:47
```

### Modifications

- Use `std::shared_ptr` instead of `std::unique_ptr` for `AckGroupingTrackerEnabled`, then capture the shared pointer in timer callback's lambda expression to extend the lifetime of `this`.
- Add `start()` method to `AckGroupingTracker` to avoid `std::bad_weak_ptr` because `shared_from_this()` in a constructor returns a null pointer.
- Use `std::weak_ptr` to reference `HandlerBase` in case that the handler may be invalid when the timer callback is triggered.
codelipenghui pushed a commit that referenced this issue Nov 12, 2020
@BewareMyPower @codelipenghui
[C++] Fix potential crash caused by AckGroupTracker's timer (#8519)
98591c4 
### Motivation

The `AckGroupingTrackerEnabled`'s timer callback only captures `this`, which is a weak reference to the `AckGroupingTrackerEnabled ` instance. If the instance went out of the scope and destroyed, `this` would point to an invalid block.

Even if the destructor of `AckGroupingTrackerEnabled` cancels the timer, the callback may not be triggered immediately. There's still a possibility that when the callback is triggered, the error code is 0 but accessing to `this` is invalid. For example, there's a crash caused by the callback in production environment that is hard to reproduce:

```
#6 <signal handler called>
#7 0x00007fb4e67c5cb8 in ?? ()
#8 0x00007fb604981adb in operator() (ec=..., __closure=0x7fb52b0fb230)
   at /usr/local/src/apache-pulsar-microfocus/pulsar-client-cpp/lib/AckGroupingTrackerEnabled.cc:148
#9 operator() (this=0x7fb52b0fb230) at /usr/local/include/boost/asio/detail/bind_handler.hpp:47
```

### Modifications

- Use `std::shared_ptr` instead of `std::unique_ptr` for `AckGroupingTrackerEnabled`, then capture the shared pointer in timer callback's lambda expression to extend the lifetime of `this`.
- Add `start()` method to `AckGroupingTracker` to avoid `std::bad_weak_ptr` because `shared_from_this()` in a constructor returns a null pointer.
- Use `std::weak_ptr` to reference `HandlerBase` in case that the handler may be invalid when the timer callback is triggered.

(cherry picked from commit cfa65d0)
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this issue Nov 17, 2020
@BewareMyPower @flowchartsman
[C++] Fix potential crash caused by AckGroupTracker's timer (apache#8519
c64ea7d 
)

### Motivation

The `AckGroupingTrackerEnabled`'s timer callback only captures `this`, which is a weak reference to the `AckGroupingTrackerEnabled ` instance. If the instance went out of the scope and destroyed, `this` would point to an invalid block.

Even if the destructor of `AckGroupingTrackerEnabled` cancels the timer, the callback may not be triggered immediately. There's still a possibility that when the callback is triggered, the error code is 0 but accessing to `this` is invalid. For example, there's a crash caused by the callback in production environment that is hard to reproduce:

```
#6 <signal handler called>
apache#7 0x00007fb4e67c5cb8 in ?? ()
apache#8 0x00007fb604981adb in operator() (ec=..., __closure=0x7fb52b0fb230)
   at /usr/local/src/apache-pulsar-microfocus/pulsar-client-cpp/lib/AckGroupingTrackerEnabled.cc:148
apache#9 operator() (this=0x7fb52b0fb230) at /usr/local/include/boost/asio/detail/bind_handler.hpp:47
```

### Modifications

- Use `std::shared_ptr` instead of `std::unique_ptr` for `AckGroupingTrackerEnabled`, then capture the shared pointer in timer callback's lambda expression to extend the lifetime of `this`.
- Add `start()` method to `AckGroupingTracker` to avoid `std::bad_weak_ptr` because `shared_from_this()` in a constructor returns a null pointer.
- Use `std::weak_ptr` to reference `HandlerBase` in case that the handler may be invalid when the timer callback is triggered.
hrsakai pushed a commit to hrsakai/pulsar that referenced this issue Dec 10, 2020
@wolfstudy @merlimat
refactor the project's directory structure (apache#7)
9e3736a 
Signed-off-by: xiaolong.ran <ranxiaolong716@gmail.com>
@LutzWeischerFujitsu LutzWeischerFujitsu mentioned this issue Mar 17, 2021
Closed
hangc0276 referenced this issue in hangc0276/pulsar May 26, 2021
@sijie @jiazhai
Add issue templates and code owner (#7)
1e21036
@xiaotongwang1 xiaotongwang1 mentioned this issue Aug 4, 2021
Closed
@iTigeroar iTigeroar mentioned this issue Nov 19, 2021
Closed
@paladin-dalao paladin-dalao mentioned this issue Jan 13, 2022
Closed
@zhcn zhcn mentioned this issue Aug 25, 2022
Closed
2 tasks
codelipenghui pushed a commit that referenced this issue Oct 10, 2022
@Pomelongan
[cleanup][broker]remove methods no longer used in AdminResource #7 (#…
ca648b2 
…17969)
@ZHr-UChiHa ZHr-UChiHa mentioned this issue Jun 3, 2023
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@merlimat merlimat

Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@merlimat @yiguolei