Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] [cli] Pulsar Tokens Create is mishandling time units (specifically, treating seconds as milliseconds) #22811

Closed
3 tasks done
entvex opened this issue May 30, 2024 · 1 comment · Fixed by #22815
Closed
3 tasks done

[Bug] [cli] Pulsar Tokens Create is mishandling time units (specifically, treating seconds as milliseconds) #22811

entvex opened this issue May 30, 2024 · 1 comment · Fixed by #22815
Assignees
@entvex
Labels
type/bug The PR fixed a bug or issue reported a bug

Comments

@entvex
Copy link
Contributor

entvex commented May 30, 2024 •
edited
Loading

Search before asking

  • I searched in the issues and found nothing similar.

Read release policy

  • I understand that unsupported versions don't get bug fixes. I will attempt to reproduce the issue on a supported version of Pulsar client and Pulsar broker.

Version

The versions affected 3.2.0 3.2.1 3.2.2 and 3.2.3

Minimal reproduce step

Create a JWT token using an affected version.
bin/pulsar tokens create --secret-key /pulsar/secret.key --subject test-user --expiry-time 3600s
Use a JWT decoder and you will see that the expiry time is wrong.

What did you expect to see?

A JWT token with the desired --expiry-time

What did you see instead?

As a workaround, you can multiply the --expiry-time by 1000 if you specify s in at the end of --expiry-time. To convert it to mili sec.

The mentioned bug affects all time units, not just seconds.

Anything else?

It appears that the bug was introduced in this pull request: GitHub link. I'll work on fixing it and submit a pull request. Additionally, I'll look into adding test coverage.

Are you willing to submit a PR?

  • I'm willing to submit a PR!
@entvex entvex added the type/bug The PR fixed a bug or issue reported a bug label May 30, 2024
@entvex entvex self-assigned this May 30, 2024
@lhotari
Copy link
Member

lhotari commented May 30, 2024

this is a regression caused by https://github.com/apache/pulsar/pull/21412/files changes.

This was referenced May 31, 2024
Merged
Merged
HofmeisterAn added a commit to testcontainers/testcontainers-dotnet that referenced this issue Sep 3, 2024
@entvex @HofmeisterAn
chore: Apply fix for github.com/apache/pulsar/issues/22811 only for a…
934d7f0 
…ffected versions (#1232)

Co-authored-by: David Jensen <djn@danskecommodities.com>
Co-authored-by: Andre Hofmeister <9199345+HofmeisterAn@users.noreply.github.com>
This was referenced Sep 3, 2024
Closed
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Open
Merged
Closed
Merged
Closed
Merged
This was referenced Sep 30, 2024
Closed
Closed
Merged
Closed
Closed
Closed
Open
Merged
Closed
Closed
This was referenced Oct 7, 2024
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Oct 14, 2024
Closed
Closed
Closed
Closed
Merged
Merged
This was referenced Oct 21, 2024
Merged
Closed
Closed
This was referenced Nov 4, 2024
Closed
Merged
Closed
@dependabot dependabot bot mentioned this issue Nov 18, 2024
Closed
@dependabot dependabot bot mentioned this issue Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@entvex entvex

Labels
type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[fix][cli] Fix expiration of tokens created with "pulsar tokens create" entvex/pulsar
2 participants
@lhotari @entvex