[pulsarbot] Handle bug in "/pulsarbot rerun-failure-checks" that reruns obsolete jobs #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
eolivelli,
codelipenghui,
dave2wave and
michaeljmarshall
lhotari
force-pushed
the
lh-fix-rerunning-obsolete-jobs
branch
5 times, most recently
from
4a37d8f to
df0e973
Compare
…n obsolete jobs - only the most recent job should be considered for failed jobs
lhotari
force-pushed
the
lh-fix-rerunning-obsolete-jobs
branch
from
df0e973 to
0bf1733
Compare
nicoloboschi
approved these changes
Apr 21, 2022
eolivelli
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently "/pulsarbot rerun-failure-checks" might rerun obsolete jobs. The jobs to rerun are searched by the PR's head commit SHA. If the PR is closed and re-opened or the complete workflow is re-run, the PR head commit SHA doesn't change.
Only the most recent job of each unique workflow should be considered for rerunning.
Modifications
Additional context
dev mailing list thread https://lists.apache.org/thread/n05xp17krb4f3cc0jjkh65ytqk1w6130