Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new GitHub API to re-run failed jobs #27

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Mar 23, 2022

This change is needed for apache/pulsar#14819 so that using "/pulsarbot rerun-failure-checks" would re-run only the failed jobs instead of restarting the failed workflows completely from the beginning.

I have tested that the modified script works as expected.

Copy link
Member

@michaeljmarshall michaeljmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great change @lhotari!

@codelipenghui codelipenghui merged commit 078fe33 into apache:master Mar 24, 2022
@nodece
Copy link
Member

nodece commented Apr 7, 2022

@lhotari @michaeljmarshall @codelipenghui This PR breaks the /pulsarbot rerun-failure-checks feature, I submitted #28 to fix this, could you review this PR? Thanks for your time.

@lhotari
Copy link
Member Author

lhotari commented Apr 7, 2022

@lhotari @michaeljmarshall @codelipenghui This PR breaks the /pulsarbot rerun-failure-checks feature, I submitted #28 to fix this, could you review this PR? Thanks for your time.

I replied in #28 (comment) .

@nodece
Copy link
Member

nodece commented Apr 8, 2022

This PR is working, thanks for the @lhotari explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants