Fix conflicts with other python libraries due to static link to libgcc and libstdc++ #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
force-pushed
the
bewaremypower/fix-glibc-conflicts
branch
from
21727a2 to
08c5ce4
Compare
BewareMyPower
changed the title
merlimat
approved these changes
Feb 7, 2025
| @@ -46,6 +47,9 @@ if [ $CPP_BINARY_TYPE == "rpm" ]; then | |||
| cd .. | |||
| ./bootstrap-vcpkg.sh | |||
| cd .. | |||
| if [ $PULSAR_CPP_VERSION == "3.7.0" ]; then | |||
| patch lib/CMakeLists.txt $ROOT_DIR/pkg/manylinux2014/pulsar-client-cpp-3.7.0.patch | |||
There was a problem hiding this comment.
For next versions, should we just fix this in cpp repo build file? At least add a build option
There was a problem hiding this comment.
Yes, I pushed a PR here: apache/pulsar-client-cpp#474
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #242
Fixes #243
Fixes #245
Add a patch to avoid linking to libgcc and libstdc++.