-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add open tracing to pulsar go clinet #518
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maraiskruger1980 Great Job., thanks for your contribution. Can you add some test cases for this?
It seems that we can also add similar functions to the reader. Are you also interested in this?
For this, you can also send a new pull request to impl it. |
@wolfstudy I added tests and made some improvements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
Here is the PR to add open tracing to the pulsar go client directly. |
@@ -0,0 +1,40 @@ | |||
### Usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maraiskruger1980 thanks for your contribution! Want users to know this great feature and know how to use it?
If so, could you please add docs to Pulsar - Go client?
(How about adding a section "Monitoring" and add the docs under that section? Explanations of "What is the feature" & "How to use the feature" are needed. You can take How to trace Pulsar messages with OpenTracing and Jaeger and OpenTracing Pulsar Client as references.
Then I would like to help review. Feel free to ping me if needed, thanks.
As suggested by @sijie
Here is the PR to add open tracing to the pulsar go client directly.
This is replicating what the java tracer does:
https://github.com/streamnative/pulsar-tracing
The usage is stipulated in the readme.md file