Fix token refresh test case in PolarisApplicationIntegrationTest #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding token expiry time is not necessary for these tests. Use normal `AuthConfig` builder for setting the OAuth2 URI.
dimas-b
requested review from
adutra,
ashvina,
eric-maynard,
jackye1995,
jbonofre,
vvcephei,
collado-mike,
snazy,
RussellSpitzer,
takidau,
flyrain and
ebyhr
as code owners
dimas-b
changed the title
adutra
approved these changes
Jan 8, 2025
dimas-b
added a commit
to dimas-b/polaris
that referenced
this pull request
Jan 9, 2025
Use an explicit fake and expired token as input to the Iceberg's `AuthSession` to force it to obtain a real token from Polaris at session creation time. This is a follow-up to apache#629. Before that PR, the test depended heavily on Iceberg's `AuthSession` code. It still depends on that, but to a lesser extent. Now, the input token is already expired, so the test only needs to validate that a new token was obtained.
Merged
adutra
pushed a commit
that referenced
this pull request
Jan 9, 2025
Use an explicit fake and expired token as input to the Iceberg's `AuthSession` to force it to obtain a real token from Polaris at session creation time. This is a follow-up to #629. Before that PR, the test depended heavily on Iceberg's `AuthSession` code. It still depends on that, but to a lesser extent. Now, the input token is already expired, so the test only needs to validate that a new token was obtained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary Mockito Spies. Overriding token expiry time is not necessary for these tests.
Use normal
AuthConfigbuilder for setting the OAuth2 URI.