Pass RealmContext instance to all API methods #566
Conversation
adutra
requested review from
jbonofre,
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike and
ebyhr
as code owners
| AuthenticatedPolarisPrincipal authenticatedPrincipal = | ||
| (AuthenticatedPolarisPrincipal) securityContext.getUserPrincipal(); | ||
| if (authenticatedPrincipal == null) { | ||
| throw new NotAuthorizedException("Failed to find authenticatedPrincipal in SecurityContext"); | ||
| } | ||
|
|
||
| PolarisEntityManager entityManager = | ||
| entityManagerFactory.getOrCreateEntityManager(callContext.getRealmContext()); | ||
| entityManagerFactory.getOrCreateEntityManager(realmContext); |
There was a problem hiding this comment.
Can RealmContext be a @RequestScoped injectable (constructor) property as opposed to an explicit method parameter?
There was a problem hiding this comment.
No, for 2 reasons: 1) DW does not "understand" request-scoped REST resources, and 2) Quarkus will need the parameter anyway, to add the realm id to the generated metric tags. IOW, later on the parameter will be annotated with @MeterTag as follows:
@Context
@MeterTag(key="realm_id",expression="realmIdentifier")
RealmContext realmContext,There was a problem hiding this comment.
Hypothetically: is it possible to manually produce a @RequestScoped bean for the realm context data in the generated API code?
| CallContext callContext = CallContext.getCurrentContext(); | ||
| PolarisCallContext polarisCallContext = callContext.getPolarisCallContext(); | ||
| PolarisCallContext polarisRealmContext = | ||
| CallContext.getCurrentContext().getPolarisCallContext(); |
There was a problem hiding this comment.
Why rename this variable?.. It looks like its value did not change? 🤔
There was a problem hiding this comment.
Oh sorry, result of successive refactorings 🤦♂️
This is a first step towards fixing #463.
RealmContextis now passed as an argument to every API and Service method generated from OpenAPI specs. Passing theRealmContextis also a prerequisite for including the realm ID as a custom tag in generated metrics.