Upgrade Hadoop and Dropwizard versions and exclude non-Apache compliant transitive dependencies #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt transitive dependencies
jbonofre
requested review from
ashvina,
RussellSpitzer,
snazy,
vvcephei,
takidau,
jackye1995,
flyrain,
eric-maynard,
collado-mike,
ebyhr and
adutra
as code owners
|
NB: I'm investigating why renovate is not triggering (checking in asf hooks). |
snazy
reviewed
Dec 10, 2024
| @@ -41,6 +41,11 @@ dependencies { | |||
| exclude("ch.qos.reload4j", "reload4j") | |||
| exclude("log4j", "log4j") | |||
| exclude("org.apache.zookeeper", "zookeeper") | |||
| exclude("org.apache.hadoop.thirdparty", "hadoop-shaded-protobuf_3_25") | |||
There was a problem hiding this comment.
Can these be removed from the LICENSE* files then?
There was a problem hiding this comment.
It's not in the LICENSE file.
There was a problem hiding this comment.
This transitive is introduced by Hadoop update.
There was a problem hiding this comment.
No, the others dependencies are coming also from hadoop for ages. I exclude these dependencies (old jersey version) because they are GPL dependencies (not ASF compliant).
There was a problem hiding this comment.
The "old" jersey dependencies are removed from the LICENSE.bin file in the other PR.
There was a problem hiding this comment.
I don't mind in which PR its done, so +1
snazy
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.